search

RobotecAI / ros2cs

A C# (.Net) implementation of ros2 client library (rcl), enabling communication between ros2 ecosystem and C#/.Net applications such as Unity3D
Apache License 2.0
89 stars 22 forks source link

service complete version commit #30

Closed miyakoshi-dev closed 1 year ago

miyakoshi-dev commented 2 years ago

@adamdbrw I have implemented the service. When you have time, could you please check it for me?

miyakoshi-dev commented 2 years ago

Now that we have completed the implementation of the service, we have closed this draft PR and created a new PR.

miyakoshi-dev commented 2 years ago

I closed this by mistake, so I will reopen it.

adamdbrw commented 2 years ago

Thank you for the contribution, it would prove very valuable indeed! We will review it with @pijaro.

adamdbrw commented 2 years ago

@pijaro if you could, please review today

pijaro commented 2 years ago

@miyakoshi-dev Thanks for the nice PR! I'm currently looking into the code. I will finish my review tomorrow :+1:

pijaro commented 2 years ago

I've added some feedback :+1: Thanks again for such an important PR :+1:

I also did a quick test on galactic and humble (u20) - it worked for galactic but failed for humble. It would be nice to keep the compatibility between ROS2 releases as well.

miyakoshi-dev commented 2 years ago

Thank you for your review. I will reflect your comments when I have time. Currently, it only supports galactic, so humble has not been verified.

miyakoshi-dev commented 2 years ago

Addressed non-Humble related review comments.

miyakoshi-dev commented 1 year ago

@pijaro @adamdbrw hello It's been a while, but now it supports humble. In addition to humble support, it supports the PR I received on my github. I have confirmed that the service works on humble/galactic on ubuntu/windows.

pijaro commented 1 year ago

I will close this PR since the work is being continued on #36 by @Deric-W :+1: @miyakoshi-dev let's continue our work there :medal_sports: