set ros2cs_tests CSHARP_TARGET_FRAMEWORK

RobotecAI / ros2cs

A C# (.Net) implementation of ros2 client library (rcl), enabling communication between ros2 ecosystem and C#/.Net applications such as Unity3D

Apache License 2.0

89 stars 22 forks source link

set ros2cs_tests CSHARP_TARGET_FRAMEWORK #44

Closed Deric-W closed 1 year ago

Deric-W commented 1 year ago

This PR fixes Issue #39 and a part of Issue #43 by setting CSHARP_TARGET_FRAMEWORK for ros2cs_tests to netcoreapp6.0 to prevent using the new fallback. It also updates the installation READMEs.

adamdbrw commented 1 year ago

Thank you for the contribution! @pijaro will review this after he comes back from the leave (next week). Apologies for the delay!

pijaro commented 1 year ago

This PR could be useful. Any reason you decided to close it? 🤔