search

RocketChat / Apps.Github22

The ultimate AI-powered app extending Rocket.Chat for global developers collaborating on Github (2024 and beyond)
33 stars 37 forks source link

[BUG] Invalid PR number not detected #140

Closed JeffreytheCoder closed 5 months ago

JeffreytheCoder commented 5 months ago

Description:

When running /gh [repo] pulls #PR where #PR doesn't exist, the app crashes.

Steps to reproduce:

Run /gh [repo] pulls #PR where #PR doesn't exist

Expected behavior:

Detect invalid #PR and notify the user.

Actual behavior:

RC crashes with the following error:

Screenshot 2024-03-04 at 3 05 26 PM
samad-yar-khan commented 5 months ago

@JeffreytheCoder thanks, seems like a valid issue, we should have some handling for this

JeffreytheCoder commented 5 months ago

@samad-yar-khan cool! could you review the PR?