RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.02k stars 10.32k forks source link

Rocket Chat window overrun by MSConnect #13287

Open BrusselsSprout opened 5 years ago

BrusselsSprout commented 5 years ago

Description:

When Rocket Chat is active and I connect to the WiFi at McDonalds the Rocket Chat window becomes the web browser sign in for the WiFi

Steps to reproduce:

  1. Start Rocket chat on home network
  2. take your computer to McDonalds for lunch
  3. Connect to McDonalds WiFi
  4. Watch RocketChat window process MS Connect network authentication

Expected behavior:

McDonalds WiFI sign in should not take over RocketChat

Actual behavior:

rocket chat wifi sign in

Server Setup Information:

Additional context

Relevant logs:

bkraul commented 5 years ago

I don't think Rocket.Chat has any control over that. At the very best they could add a check on the client side to detect no connection, but I this should already be in place. In fact, I think the client detects a connection because you technically "do" have internet, but it is limited to the sign-in portal. Regardless this issue should probably be moved to the RocketChat.Electron issue board.

Usually wifi sign-in portals are designed to overtake any http/https communication until you agree to the terms and truly connect. The Electron RocketChat client is first and foremost a web browser. This means you need to ensure connection in a browser before you try to use Rocketchat. If you have Rocket.Chat starting up automatically, close it completely, connect to the wifi (by signing in through the web portal), and then reopen RocketChat, and it should operate as normal.