search

RogerCrocker / BadaBib

20 stars 5 forks source link

Abstract is unreadable in dark mode adwaita. #7

Closed vasholotl closed 2 years ago

vasholotl commented 2 years ago

Here's what it looks like in light mode of a sample article image

Here's what it looks like in dark mode image

The text box should either keep the dark text or switch the background color of the abstract text box to a darker color for better contrast. I think the second solution would be better suited for dark mode.

RogerCrocker commented 2 years ago

Hi! This is strange. Is this the Flatpak version? And are you using a custom GTK theme?

This is what the abstract looks like for me:

Screenshot_Abstract

vasholotl commented 2 years ago

Hello! I am using the flatpak version on Fedora 36 but no custom GTK theme, just default adwaita dark theme. I found something interesting about the bug. If dark mode is turned on in the Baba Bib! preferences it renders the text box color correctly but if it's done by the built-in Gnome settings method the bug occurs. You can leave dark mode permanently on of course but it wouldn't respect the Gnome light/dark mode and it doesn't work well with extensions that changes the mode automatically depending on the time.

RogerCrocker commented 2 years ago

Right, that makes sense. Bada Bib! applies some style changes on top of the ones triggered by the system. This is to work around a missing style class in libadwaita. I think there is a way to make sure that these changes are also applied when the system wide theme changes, but I need to look into that...

RogerCrocker commented 2 years ago

The latest commits should have fixed this issue. I'll try to make a bug fix release within the next couple of days.