Romern / syncMyMoodle

Synchronization client for RWTH Moodle
GNU General Public License v3.0
72 stars 18 forks source link

Update README.md #51

Closed HarHarLinks closed 3 years ago

HarHarLinks commented 3 years ago

the secret service documentation did not match the code.

https://github.com/Romern/syncMyMoodle/blob/93528b25676a4ed49cefc756975142702c9e3447/syncMyMoodle.py#L608 means that subsequently https://github.com/Romern/syncMyMoodle/blob/93528b25676a4ed49cefc756975142702c9e3447/syncMyMoodle.py#L633 is always hit when supplying a --password on cli and secretservice is enabled.

Arguably, you always want to use secret service if possible in order to avoid storing your password in plain text, which is likely to happen when using the cli arg (history). Perhaps you should go so far as recommending it if possible. It should even work on windows and headless linux (eg wsl), with slight tweaking.

Romern commented 3 years ago

you're right, thanks :+1: