RonasIT / laravel-empty-project

7 stars 2 forks source link

#43: Updated linter and formatter packages #72

Closed ulin-evgeny closed 8 months ago

ulin-evgeny commented 8 months ago
  1. I disabled the MailableMethodsInBuild rule for tlint because tlint considers the file BaseMail.php invalid. But if you change the file as required tlint, then the changed area cannot be covered with tests - this is written in the comments in the file code (codeCoverageIgnore).
  2. I disabled the AlphabeticalImports rule for tlint, because tlint considers function imports the same as class imports, which contradicts PSR-12, in which says that function imports should be separate.
  3. To sort imports, it is possible to replace tlint with PHP CS Fixer, but I did not do this because PHP CS Fixer also does not handle sorting well imports in classes where there is a function imports - for some reason, it separates some class imports with an empty string.