Slugs with special characters

[marcusnovotny]

Hey there Project A!

We over at ProjectD_Group4 (#90) noticed that the provided slugs don't work for Character with special characters in their name, for example this fellow Jaqen H'Ghar.

Looking forward to your reply :)

[kordianbruck]

I'm guessing you are talking about https://got-api.bruck.me/api/characters/byId/56f5c296be62dc6e12808a60 and that the ' is not removed, yes?

[marcusnovotny]

Yes, right now the ' breaks our XMLHttpRequest

[Legenzoo]

We are just using the slugs from the wiki, which are unfortunately not handling this. See http://awoiaf.westeros.org/index.php/Jaqen_H%27ghar .

Probably just remove the " ' "? I don´t think that this will lead to naming conflicts.

[kordianbruck]

Replacing it with an additional _ should work though.

[kordianbruck]

Actually: @marcusnovotny did you try escaping your URL?

http://stackoverflow.com/questions/6544564/url-encode-a-string-in-jquery-for-an-ajax-request

[marcusnovotny]

Using Jaqen_H%27ghar as a slug doesn't work aswell

[Legenzoo]

@kordianbruck I replace them by _, but the db needs to be updated =/

[kordianbruck]

@sacdallago please update the character DB

[sacdallago]

@kordianbruck you were dying for the first time you could say this, weren't you? :D :D

[sacdallago]

Ehm...:

Yohn Royce is updated.
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError
SUCCESS: MongoError

Updating pageRanks..
Addam Frey has no image. Score divided by two!
Abelar Hightower has no image. Score divided by two!
Addam Marbrand got updated by the page rank 40
Addam Osgrey has no image. Score divided by two!
Addam has no image. Score divided by two!
Addam Velaryon got updated by the page rank 33
Addison Hill has no image. Score divided by two!
Aegon Blackfyre got updated by the page rank 26
Aegon III Targaryen got updated by the page rank 188
Aegon II Targaryen got updated by the page rank 228
Aegon I Targaryen got updated by the page rank 300
Aegon IV Targaryen got updated by the page rank 25
Aegon Targaryen (son of Aenys I) got updated by the page rank 194
Aegon V Targaryen got updated by the page rank 30
Aegor Rivers got updated by the page rank 64
Aelinor Penrose has no image. Score divided by two!
Aemma Arryn has no image. Score divided by two!
Aemon Estermont has no image. Score divided by two!
Aemon Costayne has no image. Score divided by two!
Aemon Blackfyre got updated by the page rank 27
Aemon Rivers has no image. Score divided by two!
Aemond Targaryen got updated by the page rank 94
Aenys Frey got updated by the page rank 45
Aerion Targaryen got updated by the page rank 63
Aenys I Targaryen got updated by the page rank 172
Aeron Greyjoy got updated by the page rank 138
Aerys II Targaryen got updated by the page rank 300
Aerys I Targaryen got updated by the page rank 187
Aethelmure has no image. Score divided by two!
Aethan has no image. Score divided by two!
Aggar has no image. Score divided by two!
Aggo got updated by the page rank 41
Aglantine has no image. Score divided by two!
Agrivane has no image. Score divided by two!
Aladale Wynch has no image. Score divided by two!
Alan has no image. Score divided by two!
Alannys Harlaw got updated by the page rank 72
Alayaya got updated by the page rank 24
Alaric of Eysen has no image. Score divided by two!
Albar Royce got updated by the page rank 11
Albett has no image. Score divided by two!
Alebelly has no image. Score divided by two!
Alekyne Florent has no image. Score divided by two!
Alequo Adarys has no image. Score divided by two!
Alerie Hightower got updated by the page rank 69
Alesander Frey has no image. Score divided by two!
Alesander Torrent has no image. Score divided by two!
Alesander Staedmon has no image. Score divided by two!
Alester Norcross has no image. Score divided by two!
Alester Oakheart has no image. Score divided by two!
Alfyn got updated by the page rank 1
Alia has no image. Score divided by two!
All-for-Joffrey has no image. Score divided by two!
Alicent Hightower got updated by the page rank 81
Alla Tyrell has no image. Score divided by two!
Allaquo has no image. Score divided by two!
Allar Deem has no image. Score divided by two!
Allard Seaworth has no image. Score divided by two!
Alliser Thorne got updated by the page rank 70
Allyria Dayne has no image. Score divided by two!
Alvyn Sharp has no image. Score divided by two!
Alyce Graceford has no image. Score divided by two!
Alyce has no image. Score divided by two!
Alyn Ambrose has no image. Score divided by two!
Alyn Cockshaw has no image. Score divided by two!
Alyn Connington has no image. Score divided by two!
Alyn Estermont has no image. Score divided by two!
Alyn Frey has no image. Score divided by two!
Alyn Haigh has no image. Score divided by two!
Alyn Hunt has no image. Score divided by two!
Alyn Stackspear has no image. Score divided by two!
Alyn Velaryon has no image. Score divided by two!
Alyn got updated by the page rank 23
Alys Arryn has no image. Score divided by two!
Alys Frey has no image. Score divided by two!
Alys Karstark got updated by the page rank 48
Alysane Mormont got updated by the page rank 22
Alysanne Bracken has no image. Score divided by two!
Alysanne Hightower has no image. Score divided by two!
Alysanne Bulwer has no image. Score divided by two!
Alysanne of Tarth has no image. Score divided by two!
Alyssa Arryn has no image. Score divided by two!
Alysanne Lefford has no image. Score divided by two!
Alysanne Osgrey has no image. Score divided by two!
Alysanne Targaryen got updated by the page rank 84
Alyx Frey has no image. Score divided by two!
Ambrode has no image. Score divided by two!
Amabel has no image. Score divided by two!
Amarei Crakehall has no image. Score divided by two!
Alyssa Blackwood has no image. Score divided by two!
Ambrose Butterwell has no image. Score divided by two!
Amory Lorch got updated by the page rank 84
Andar Royce has no image. Score divided by two!
Amerei Frey got updated by the page rank 72
Anders Yronwood got updated by the page rank 19
Andrey Charlton has no image. Score divided by two!
Andrew Estermont has no image. Score divided by two!
Andrey Dalt has no image. Score divided by two!
Andrik got updated by the page rank 14
Andros Brax has no image. Score divided by two!
Androw Ashford got updated by the page rank 6
Androw Frey has no image. Score divided by two!
Anguy got updated by the page rank 40
Annara Farring has no image. Score divided by two!

[Legenzoo]

I fixed it and moved the download of the characterImages into a new filling process. Took way too long. npm run update --collection=characterImages to download the images and update the links in the db.

[sacdallago]

Updated, restarted forever