search

Rothamsted / knetminer

KnetMiner - webapp to search and visualize genome-scale knowledge graphs
https://knetminer.com
MIT License
25 stars 16 forks source link

Should we remove JSP tags? #638

Open marco-brandizi opened 2 years ago

marco-brandizi commented 2 years ago

The Knetminer client is rendered by means of a small JSP/tag library (see .tag files in client-base/).

This is usually done when some modularity is needed, eg, a set of generic widgets to be used to compose an application-specific case. Apart from the fact that nowadays there are simpler ways to do the same using Javascript only, the current code is very Knetmkiner-specific and there isn't much benefit in using tags inside an empty JSP page, wrt using the same HTML code that comes from the tags directly into the JSP.

So, should migrate it to plain JSP?

KeywanHP commented 2 years ago

Sounds good if it simplifies and modernizes the code base. Do you agree @manlikleo ?

lawal-olaotan commented 2 years ago

Checking the .tag files in the client base, The files structure could be replicated with EJS templating style, also I have little on knowledge with JSP. I can do my own research and suggest ideas.

marco-brandizi commented 2 years ago

This isn't urgent. I've created this issue mostly as a reminder. Let's not start working on new tasks without having first decided we want to do it.