search

Rotonde / rotonde-client

Rotonde Base Client
https://client-neauoire.hashbase.io/
MIT License
227 stars 49 forks source link

Mentions not working #102

Closed dcposch closed 7 years ago

dcposch commented 7 years ago

Client version: 0.1.68 Beaker version: 0.7.7 URL to reproduce: dat://beddfd47e26d685d075410d16ed68fecbad686b837005f5dc8082fa9bae78cff/#mentions

my Rotonde portal says I have three mentions, but when I click on that tab I get nothing:

image

there are no exceptions in the console, but there are a few "connection failed" messages:

image

dcposch commented 7 years ago

rotonde is amazing btw. i love the minimalist aesthetic

@neauoire

eelfroth commented 7 years ago

yeah I've noticed it broke again… I'm on it!

0x0ade commented 7 years ago

I've noticed that we're counting the mentions separately from all other entries... and that the "Entries" tab number counts "invisible" entries, too.

In feed.js, we could update the for(id in sorted_entries){ to count all visible entries (f.e. c_all or short, ca) and make the "Entries" tab use that instead. Something similar could be applied for mentions to only count "visible" mentions. This would mean that right now, something's either wrong with the mention filtering, or with how mentions are counted.

(By the way, I'm supporting your comment. Rotonde really is amazing!)

eelfroth commented 7 years ago

for(id in sorted_entries){ is stopping after 40 entries though: if(c > 40){ break; }. In my opinion, that loop and the refresh function should only be used for displaying the feed, not analysing it for categories like mentions/whispers, that should already have happened at that point. I prefer counting entries when they are created (as in, a Portal instance creates an instance of the Entry object) The reason it's broken at the moment is because we are counting in multiple places

0x0ade commented 7 years ago

I rather meant the following check with "visible" / "invisible" entries, should've been clearer 😅: if(!entry.is_visible(r.home.feed.filter,r.home.feed.target)){ continue; }

Haven't taken a deep look yet, just wondering if a difference between the mention counter and is_visible could cause the mismatch.