Closed 0x0ade closed 7 years ago
thanks for escaping those. nobody bothered to fix that security hole until now ¯\_(ツ)_/¯
I just noticed that names are affected, too; Lemme commit a fix for that, too
I'll merge when names are escaped as well :)
This commit doesn't only escape names, but also targets. r.escape_html
and r.escape_attr
have been added for any future escaping needs :)
Thanks a lot for this, I will give it its own version and seed it right away!
Rotonde doesn't escape the entry
media
, which allows anyone to hide anything in there.Same goes to
client_version
:This changeset escapes the media URL using
encodeURI
and changes the portal version handling toI don't know how "strict" it should be, so I left room for some customization of the client version.