Roverok / libnfc

Automatically exported from code.google.com/p/libnfc
GNU Lesser General Public License v3.0
0 stars 0 forks source link

Produce error codes when something goes wrong #65

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. libnfc doesn't report what kind of error we are facing of when error.

What is the expected output? What do you see instead?
We can at least use E_errors on Unix and ERROR_BAD_DEVICE,
ERROR_NOT_READY, ERROR_IO_DEVICE, etc on Windows (suggested by snapdev on
forum¹)

[1] http://www.libnfc.org/community/post/599/#p599

Original issue reported on code.google.com by romu...@libnfc.org on 17 Feb 2010 at 5:03

GoogleCodeExporter commented 9 years ago
Quotting r380 changelog entry:
We should rely on error codes and maybe some logging mechanism (e.g. syslog() 
on POSIX compliant systems 
and RegisterEventSource() / ReportEvent() on Windows).

Original comment by romain.t...@gmail.com on 16 Apr 2010 at 2:51

GoogleCodeExporter commented 9 years ago

Original comment by romu...@libnfc.org on 21 Apr 2010 at 1:15

GoogleCodeExporter commented 9 years ago
This is WIP allong with issue 61 in the libnfc-error-handling branch.

Original comment by romain.t...@gmail.com on 26 Jul 2010 at 12:54

GoogleCodeExporter commented 9 years ago
This issue was updated by revision r528.

New review:
Owner: rconty@il4p.fr
Cc: rtartiere@il4p.fr
Summary: Review the error-handling code.
Branch: /branches/libnfc-error-handling

For this development, a strong emphasis has been set on making changes that
will not go through our way on the way to libnfc-1.6+.  For this reason, some
constructs are not natural (e.g. error codes defined in two different places),
please keep this in mind when reviewing.

Original comment by rtarti...@il4p.fr on 15 Aug 2010 at 2:08

GoogleCodeExporter commented 9 years ago
Okay… I though the column after "New review" was suspect… BTW, you got the 
idea :-)

Original comment by romain.t...@gmail.com on 15 Aug 2010 at 2:11

GoogleCodeExporter commented 9 years ago
r528 commented.
I think you could close this issue as it go the expected result for 1.4.x 
series.

Original comment by romu...@libnfc.org on 16 Aug 2010 at 3:50

GoogleCodeExporter commented 9 years ago
hmm, thinking it twice, I think issue 92 may be fixed using this error-handling 
mecanism. don't you ?

Original comment by romu...@libnfc.org on 16 Aug 2010 at 4:03

GoogleCodeExporter commented 9 years ago
Yup! I took the issue.

Original comment by romain.t...@gmail.com on 16 Aug 2010 at 7:05

GoogleCodeExporter commented 9 years ago

Original comment by romu...@libnfc.org on 19 Aug 2010 at 2:48

GoogleCodeExporter commented 9 years ago
Merged in trunk at r566.

Original comment by romain.t...@gmail.com on 20 Aug 2010 at 11:20