Rplus / Pokemon-shiny

Share personal shiny pokemon by URL!
https://rplus.github.io/Pokemon-shiny/
MIT License
80 stars 31 forks source link

Re-order families #367

Closed MelkyAir closed 1 day ago

MelkyAir commented 1 month ago

The new way of adding costumes or formes is to separate them from the regular versions. In the beginning pokemon were grouped by type, e.g smootchums by smootchums. Most have been corrected over time but there are still a few that need to be separated from families. Some are just missing the extra space between regular and costume or form.

Raticate part hat (space) Hisuian Voltorb and Electrode (separate) Galarian Exeggutor (space) Galarian Marowak (space) Smootchum bow (separate) Lapras bowtie and Lapras bow (space) Eevee red part hat (space) Glaceon winter outfit (space) Aerodactyl satchel (separate) Snorlax cowboyhat (separate) Dragonite bowtie (space) Togepi, Togetic, Togekiss flowercrown (separate) Wobbuffet partyhat (space) Hisiuan Qwilfish and Overqwil (separate) Delibird bow (space) Stantler bells (space) Wurmple partyhat (space) Kirlia tophat (separate) Absol sunnies (separate) Spheal scarf (separate) Turtwig, Chimchar and Puplip red and white cap (space) Shinx tophat (separate) Buneary and Lopunny flowercrown (separate)

@BartmanEH when you have time, can you look at these?

BartmanEH commented 1 month ago

[...] Most have been corrected over time but [...]

I corrected as many as I could. The problem is that the really old entries have old formatting without the required fields to cause the separation. I don't want to convert the old entries to the new format since RPlus was going to refactor the whole project and didn't want us to mess with the old entries. @Rplus may I convert some old entries to the new format to enable the parameters to allow for separation etc.?

Rplus commented 1 month ago

If you give pm a new family, they will be separated group. sorry for refactoring project delay

BartmanEH commented 1 month ago

If you give pm a new family, they will be separated group.

Ok I will try just changing family name of costume pm to have unique ending.

sorry for refactoring project delay

Hey no worries! This is not your hobby anymore. Although writing software is maybe your hobby.

BartmanEH commented 1 month ago

OK, my attempt to do this is PR #368

BartmanEH commented 1 month ago

The only remaining issue I see is that Holiday Costume Glaceon (pm471.cHOLIDAY_2021_NOEVOLVE) is now on its own separated too far from the Eevee families. @Rplus how can we have that Glaceon separated from the other Eevee families but still in the Eevee part of the list?

Edit: ...and as pointed out by MelkyAir, the same issue with Smoochum with Bowtie--since those two are unique family names now, they get placed by pokedex number, away from family they're supposed to be associated with.

MelkyAir commented 1 month ago

@BartmanEH also smootchum with bow is now located next to smeargle. The rest looks great, thanks for fixing this!

BartmanEH commented 1 month ago

@MelkyAir the best we can do is associate Eevee w Party Hat and Glaceon w Holiday Costume as a new 'family' so there's no space between them but they are lumped together with the other Eevee. For Smoochum w Bow Tie, the best we can do is change the order of them so regular Smoochum and Jynx are together and first, then have Smoochum with Bow Tie but with no space between it and Jynx. I have made PR #371 to finalize this issue.

BartmanEH commented 2 days ago

@Rplus did you re-open this because you have some other ideas?

Rplus commented 1 day ago

That just depends on your new PR #371