search

RubenVerborgh / AsyncIterator

An asynchronous iterator library for advanced object pipelines in JavaScript
https://rubenverborgh.github.io/AsyncIterator/docs/
Other
49 stars 7 forks source link

Fix UnionIterator not destroying sources on close #71

Closed rubensworks closed 2 years ago

rubensworks commented 2 years ago

This makes the UnionIterator aligned with the default behaviour of TransformIterators.

Given the corresponding behaviour in TransformIterator, I consider this a bugfix, so it probably doesn't require a breaking change.

This was discovered in comunica/comunica#950

coveralls commented 2 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 2b83a63556d19bbe1431b0135215295b7a5f7bce on rubensworks:fix/union-destroy into fec14f4d19e3d594bc385b927863ebf80a792580 on RubenVerborgh:main.

RubenVerborgh commented 2 years ago

Yes, thanks a lot!