RunestoneInteractive / thinkcspy

How to Think Like a Computer Scientist, Interactive Edition
https://runestone.academy/ns/books/published/thinkcspy/index.html
Other
108 stars 190 forks source link

15.32.1. Creating the View missing code #202

Open pearcej opened 2 years ago

pearcej commented 2 years ago

The active code window in 15.32.1 just says code

image

Mrjwm commented 4 weeks ago

+1 15.32.1 Creating the View, 15.32.2 Creating the Model, and 15.32.3 Creating the Controller are all missing the code. This code is expected because the last sentence of 15.32 is, "Let’s walk through the code development." Additionally, this chapter comes before the 'Classes' chapter so the code is necessary (preferably with the aforementioned supplemental walk-through) to avoid skipping ahead.

bnmnetp commented 4 weeks ago

How odd... I don't think the original author of this chapter ever finished this lesson before he retired...

I'm not really sure what to do. My first inclination would be to eliminate the reference to an improved implementation in the previous lesson, and just remove this lesson from the book.

I haven't looked at tkinter in years! And I definitely don't have the time to try to write this chapter.

Mrjwm commented 3 weeks ago

The rest of the chapter teaches TK very well, so I think omitting these sections entirely would suffice. But, FWIW, I think the (intended) value of these sections are in the implementation of the Model-View-Controller design pattern and breaking the code into modules; a very important lesson that isn't covered (beyond an introduction) anywhere else in the book.

bnmnetp commented 3 weeks ago

Sure, I would welcome a PR from anyone who had the time to fill out that section. I'm just saying that I do not have that time with everything else I have to do to keep Runestone Academy up and running.