search

RuolinZheng08 / renpy-chess

A chess GUI built with Ren'Py, python-chess, and Stockfish. Version 2.0 of https://github.com/RuolinZheng08/renpy-chess-engine
https://r3dhummingbird.itch.io/renpy-chess-game
MIT License
71 stars 13 forks source link

stockfish_20011801_x64.exe is not stopping after the game is over. #16

Closed ManWalkingInRain closed 2 years ago

ManWalkingInRain commented 3 years ago

Each time I make a move, one "stockfish_20011801_x64.exe" being added to the list. Even if the game is over, these tasks still continue to run.. And this eats so much ram :/ Adssız

RuolinZheng08 commented 3 years ago

Thanks for the detailed report! I also saw this behavior on Mac. In my newest commit, I did call stockfish_engine.quit() when the game ends, according to the doc linked to below, but the stockfish processes persist. Could be a bug in their implementation? https://python-chess.readthedocs.io/en/v0.23.10/

If you have any capacity and wouldn't mind looking into it, feel free to. I'm still trying to figure out whether their quit function does what it should do.

ManWalkingInRain commented 3 years ago

@RuolinZheng08 I searched a bit but couldn't find a solution too.. Also, i'm not very good at python :/

RuolinZheng08 commented 2 years ago

I think I've fixed this for both the 7.3.5 version and the 7.4 version, both for PvP and PvC. Please feel free to test all combinations out and let me know if you still experience issues. a6f0b783a666a9bdd9e898313782ead305b525d6 4394af31228d7912da778ceef8de0379a6965c5b