search

RustCrypto / password-hashes

Password hashing functions / KDFs
678 stars 84 forks source link

Reduce rust-version #487

Closed pflanze closed 10 months ago

pflanze commented 10 months ago

Is there a reason why rust-version for argon2 was at 1.65? I'm compiling with rustc 1.63.0 from Debian bookworm, it compiled fine and I haven't seen any issues at runtime. The increase from 1.60 was done as part of #391 but I couldn't see a reasoning and it was done for the main Cargo.toml as well, maybe it was only relevant for the main crate.

pflanze commented 10 months ago

Force-pushed to also set the MSRV for the CI.

pflanze commented 10 months ago

And force-pushed again to also change it in the tests, as well as the docs.

tarcieri commented 10 months ago

The main reason was to leave the door open to using GATs as part of a solution to #380, though granted no progress was made on that problem.

There's a high burden to maintaining older MSRVs in terms of dependency incompatibilities and overall project toil in that regard, longer compile times due to slower older compilers, and locking ourselves out of Rust features, and our upgrade cycles run quite long, so I'm just going to close this as I would prefer to upgrade, not downgrade, from MSRVs we commit to.