search

RusticiSoftware / TinCanJS

JavaScript library for the Experience API (Tin Can API)
http://rusticisoftware.github.io/TinCanJS/
Apache License 2.0
207 stars 115 forks source link

Added objectType property #26

Closed garemoko closed 11 years ago

garemoko commented 11 years ago

This fixes a bug where when getting statements if the object of the statement is an agent, the agent has no objectType property.

The code is copy and pasted from activity.js but Activity is replaced with Agent.

garemoko commented 11 years ago

Fixed as discussed

brianrogers commented 11 years ago

:thumbsup: not sure if I'm allowed to merge or if @bscSCORM needs to do it?

brianjmiller commented 11 years ago

Build files and doc regeneration still needs to occur before merge to prevent need for a second PR. I can do that tomorrow.

bscSCORM commented 11 years ago

@brianrogers yes, I need to merge, thanks. @brianjmiller I can't see how you'll avoid two PRs anyway, since it's not our branch this is coming from.... so merging, and will expect build files and doc regen as a second PR

brianjmiller commented 11 years ago

On 3/17/13 4:50 PM, bscSCORM wrote:

@brianrogers yes, I need to merge, thanks. @brianjmiller I can't see how you'll avoid two PRs anyway, since it's not our branch this is coming from.... so merging, and will expect build files and doc regen as a second PR

Nothing to say I need to be the one to do it :-). Tools are OSS and instructions provided. But I'm happy to.

Brian J. Miller Rustici Software brian.miller@scorm.com