search

Rynat86 / Better-Unlock-Info

Better Unlock Info - geode mod
1 stars 2 forks source link

fix icon size, fetch special icons and colors properly #3

Closed nytelytee closed 4 months ago

nytelytee commented 4 months ago

Icons have different scales depending on the type, so it's not always 0.8f. This adjusts the scale accordingly.

Special icons (like ship fires, animations, and colors) are not in the structure you are using to get their buttons, causing them to fail. This handles those cases.

Also unregisters force prio prior to deleting the popup.

CharacterColorPage crashes if you buy a color, and then switch to a different tab. Not sure what the cause is atm.

Rynat86 commented 4 months ago

thx, will add these in the next commit, was already working on one so I just copied it and changed it a bit. With the buy and switch crash, I have no idea, isn't happening at my end, even on the live build

nytelytee commented 4 months ago

I see the latest version's changelog includes fixing crashes when buying colors. Is that related to the thing you could not reproduce here or is it something else? If it's related, what ended up being the issue?

Rynat86 commented 4 months ago

It was something else, I didn't realize that when buying colors I'm still trying to create an icon as if you are buying icon and I end up modifying nullptr, which weirdly enough didn't happen in your clip on discord