S-101-Portrayal-subWG / Working-Documents

16 stars 5 forks source link

Portrayal of Distance Mark #162

Closed HermanSchouten closed 4 weeks ago

HermanSchouten commented 4 months ago

The Boolean attribute Distance mark visible should also control the presentation of the feature in S-101.
To resemble presentation in S-4 image So if the distance mark is visible, use the portrayal in black. If the distance mark is not visible keep current portrayal in magenta.

In many (our) cases Distance marks are just minor posts which do not have a Parent feature. Or could even be a Distance mark painted on the Quay (SLCONS), it is visible but without Parent feature. In such cases you still would want black instead of magenta display.

Dave has pointed out all the good work already done to improve the portrayal of distance mark. https://github.com/S-101-Portrayal-subWG/Working-Documents/issues/39 Making this adjustment would definitely be appreciated by data producers.

alvarosanuy commented 3 months ago

image image image image image

An option could be depicting the mark using a small black circle (similar to DISMAR05 - InlandENC) and the corresponding measuredDistanceValue when Distancemark is associated to Curve or Surface features (i.e. ShorelineConstruction).

HermanSchouten commented 3 months ago

I would rather have the boolean attribute manage the presentation. This will ease conversion from S-57 to S-101. The definition of a distance mark already has the structure feature in it. Adding a parent feature only makes sense if the parent is a significant feature. Like you would do on paper charts.

alvarosanuy commented 3 months ago

Updated version of DCEG regarding non-compulsory requirement for Structure/Equipment relationship

image

alvarosanuy commented 3 months ago

Decisions made at Portrayal subWG meeting on 10/04/24

@JeffWootton - Have we decided to make distanceMarkVisible mandatory?

@RichardCoyles - Can you create SVG+ED of the new black symbol using DISMAR06 as the starting point? I noted DISMAR05 (InlandENC) is an existing symbol in the GI Registry but it seems to be missing the center point and its line thickness looks thinner than DISMAR06..

JeffWootton commented 3 months ago

@alvarosanuy: Have we decided to make distanceMarkVisible mandatory? Yes, based on the decision made at the meeting that portrayal (black or magenta) will be based on the population of this attribute.

alvarosanuy commented 1 month ago

Can the UKHO (or others) assist with the task outlined below?

@RichardCoyles - Can you create SVG+ED of the new black symbol using DISMAR06 as the starting point? I noted DISMAR05 (InlandENC) is an existing symbol in the GI Registry but it seems to be missing the center point and its line thickness looks thinner than DISMAR06..

alvarosanuy commented 1 month ago

New DistanceMark portrayal files (Black):

DISMAR07.zip

MikusRL commented 1 month ago

Thank you for creating the symbol. Sorry for being late.

My considerations when I volunteered for the symbol. Perhaps still need to be quickly discussed through before final registration and application in the PC.
1) There are similar symbols in registry already - POSGEN 03 and 04. Not exactly alike but to consider. I guess that because the new DISMAR07 would always(?) be with the distance value label, it won't be able to mix the new symbol for these. 2) There is a NOTBRD11 which could potentially be considered to use in the portray if the distance mark is visually conspicuous. Is the number usually on the board or alike? Of course there could be an issue to portray it on top of building or alike. But so would it be for the new symbol. Should it have some offset from the building or other structure symbol? 3) Although the DISMAR07 symbol is black, I assume that the distance value still would be encoded beside them as magenta? 4) There is DISMAR03 registered. Does it need to be considered to be created as well as new symbol with the circle in black or is this particular symbol applicable only in the center line of the river, therefore always non existent and therefore magenta only?

@alvarosanuy @DavidGrant-NIWC But if this is already discussed, and is actually strait forward to implement in the PC, then please ignore the above considerations.

DavidGrant-NIWC commented 1 month ago

Although the DISMAR07 symbol is black, I assume that the distance value still would be encoded beside them as magenta?

I assume from the original request the text should be black in this case (as shown below).

Note: The portrayal checks for a StructureEquipment relationship rather than comparing the spatial.

I don't have real test data, but this should be representative: distanceMarkVisible Result
true image
false
(except leftmost)
image
alvarosanuy commented 4 weeks ago

Implemented in PC 1.4.0