In Daylight label is misleading

[calvin-fisher]

MS-R Multispectral is shown claiming no daylight while experiencing direct daylight:

Shown here claiming daylight while experiencing eclipse:

The property seems to calculate whether the craft is closer to the sun than the orbiting body, rather than whether there is direct sunlight. In a polar orbit, the setting changes between true to false only when passing over the poles.

[Kerbas-ad-astra]

The "in daylight" requirement isn't checking whether the probe is in sunlight, but whether the spot on the planet below it is in sunlight. In your first image, the probe is over the night side of the Mun, and I suppose that in the second image, the Mun is behind the camera and so the probe is over the day side. (Perhaps the Mun is being eclipsed in that image, which is not checked for.)

[DMagic1]

Yes, the daylight check is for the area of the surface being scanned, not the vessel.

The daylight check does not account for eclipses, it is a simple geometry check that can potentially be run hundreds of thousands of times per second, so it must remain as simple as possible.

[calvin-fisher]

It sounds like the calculation is doing what it's supposed to. Calling the property Surface Daylight instead of In Daylight would help clarify the purpose.

[DMagic1]

The text in the indicator has been changed to "Surface In Daylight" in version 20.2. That should be clear enough.