search

S-ResearchStack / app-sdk

Apache License 2.0
27 stars 20 forks source link

💎 Updates for Android 14 (🙃 🍰) #4

Closed naondol closed 9 months ago

naondol commented 10 months ago

Found that app-sdk needs to be updated to handle https://github.com/S-HealthStack/starter-app/issues/3

Welcomes any feedbacks!

naondol commented 10 months ago

On my second review, I found that above is used by android health platform codes, which is deprecated. I'd like to know about whether this project keeps to support android health platform or not. According to it, I will restore dependencies or resting codes of android health platform.

Jade-H commented 10 months ago
  • Remove deprecated health data dependencies

On my second review, I found that above is used by android health platform codes, which is deprecated. I'd like to know about whether this project keeps to support android health platform or not. According to it, I will restore dependencies or resting codes of android health platform.

Well, now it's time to let them go. :)

jjyun-do commented 9 months ago

Hello @naondol .

I apologize for the delayed review. Before merging the features, we reflected the PR that changes the structure to import the sample app as a submodule.

Can you please reflect the PR related to the app again here: S-HealthStack/starter-app please?

We would like to deploy the SNAPSHOT by merging your PR as well. We apologize for the inconvenience and thank you for your effort.

naondol commented 9 months ago

@jjyun-do OK. I split the original PR(https://github.com/S-HealthStack/starter-app/pull/6) according to the revised structure.