search

SABS-R3-Epidemiology / branchpro

Using branching processes to estimate the time-dependent reproduction number of a disease with imported cases
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

Separate callbacks #204

Closed I-Bouros closed 2 years ago

I-Bouros commented 2 years ago

Solves time-out issue on the branch pro web app when working with 1000 serial intervals.

codecov[bot] commented 2 years ago

Codecov Report

Merging #204 (c108c66) into main (2b18e56) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #204   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          710       710           
=========================================
  Hits           710       710

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2b18e56...c108c66. Read the comment docs.

rccreswell commented 2 years ago

@I-Bouros @DavAug the runtime is more highly dependent on the epsilon value than I realized. Lower values of epsilon mean higher values of R, which require a larger grid of R values when combining the posteriors for each serial interval. Ontario with epsilon=0.25 will need the long_callback, which I added here from the other PR. The progress bar will go separately

@DavAug ---this now contains both of our code---how about you review it next you get a chance.