search

SAIL-Labs / AMICAL

Extraction pipeline and analysis tools for Aperture Masking Interferometry mode of the last generation of instruments (ground-based and space).
https://sail-labs.github.io/AMICAL/
MIT License
9 stars 7 forks source link

Adding ERIS SAM #143

Closed JHayoz closed 2 years ago

JHayoz commented 2 years ago

Dear developers of AMICAL,

I'm participating in the commissioning of the new ERIS instrument at VLT and, along with the two coronagraphs, I'm responsible for the 3 SAM masks in NIX (SAM-7, 9, and 23). How can I add support for those in AMICAL? Is there a simple workflow to add support for a new instrument?

Thanks for your help!

Jean

DrSoulain commented 2 years ago

Hi @JHayoz, thanks for your interest :) For now, we do not have a proper workflow to add new instruments. The main requirement for AMICAL is to have access to an accurate determination of the aperture positions (compared to the pupil in meters) and the wavelength domain of the instrument (central wavelength, bandwidth, etc.). You can have a look at get_infos_obs.py to see the structure required by AMICAL.

DrSoulain commented 2 years ago

Hi again @JHayoz; additionally, if you have some simulated data, we can manage to test the pipeline on them. We probably need to know what are the appropriate header keywords to select the filters automatically, but this can be solved in a second step. Let me know when you have a reasonable estimate of your mask properties and associated spectral filters :)

JHayoz commented 2 years ago

Hi, thanks for your answers! I don't have simulated data, just data taken during commissioning. I have pupil images with the different SAM masks inserted as well as the design of the SAMs, so in principle this should provide all the data we need. I have to look into get_infos_obs.py to understand how to provide this info to AMICAL though. I'll try it this week and will probably have some more questions about AMICAL as I go.