SAME-Project / same-project

https://sameproject.ml/
Apache License 2.0
19 stars 8 forks source link

Split build/test workflows into internal and external #131

Closed Bubblyworld closed 2 years ago

Bubblyworld commented 2 years ago

Currently we do some hacks with pull_request_target to allow our build/test workflows to work for external PRs. This has some irritating drawbacks for internal PRs, however:

We should be able to fix this with a separate internal pull_request workflow and external pull_request_target workflow.

See: https://sameproject.slack.com/archives/C01LNQJ3XHU/p1652098695858589 https://github.community/t/github-actions-are-severely-limited-on-prs/18179/17

Bubblyworld commented 2 years ago

Workflow is now split 🎉 as a bonus it seemed to fix #111 too!