search

SAME-Project / same-project

https://sameproject.ml/
Apache License 2.0
19 stars 8 forks source link

Allowing unknown in runtime_options inside SameConfig #161

Closed aronchick closed 2 years ago

aronchick commented 2 years ago 
    # TODO: Not sure if this is correct (allowing unknown) - SHOULD work, since we validate elsewhere, but seems silly not to reuse the same validation rules. The reason I had to do this was in SameConfig, runtime_options does not get the same rules as we inject in options.py - it's just a dict.

https://github.com/SAME-Project/same-project/blob/dc721d320b92947397e20faebd13957730c3340c/sameproject/ops/runtime_options.py#L26