search

SAML-Toolkits / php-saml

Simple SAML toolkit for PHP
MIT License
1.21k stars 462 forks source link

validUntil updateable Metadata dependency breakage #568

Open ckbaker10 opened 7 months ago

ckbaker10 commented 7 months ago

Hello,

The validUntil field being mandatory in the generated metadata leads to the fact that metadata expiry must be monitored or automated.

Some IdPs don't provide that feature easily accessible which breaks the libraries usability

A real world example exists in Nextcloud, https://github.com/nextcloud/user_saml/issues/36

I've added a parameter to disable the validUntil from being included, as well as matching tests

Pull request: https://github.com/SAML-Toolkits/php-saml/pull/569