search

SAML-Toolkits / python3-saml

MIT License
671 stars 302 forks source link

Fix WantAuthnRequestsSigned parser #349

Closed pitbulk closed 1 year ago

pitbulk commented 1 year ago

@bitti can you confirm this is what you were expecting?

bitti commented 1 year ago

@bitti can you confirm this is what you were expecting?

I'm sorry for the late reply. I tested it today and it's working fine! Will the fix be included in the next release? It doesn't seem the failing test is related to the change at all? I wonder though if a regression test should be added for this issue. But maybe that's already implied by the changed expectations? (Which expect a boolean now instead of literal "false" and "true" strings.)

iherasymenko commented 1 year ago

@pitbulk wondering if you have a moment to merge this and release a new version. Thanks!

jhirshman commented 1 year ago

We're also waiting on a new release here. Thank you