SAML-Toolkits / ruby-saml

SAML SSO for Ruby

MIT License

924 stars 566 forks source link

Closed johnnyshields closed 4 months ago

johnnyshields commented 4 months ago

This PR catches up v2.x branch with the latest master code.

This PR also drops support for Ruby 2.6, 2.7 and JRuby 9.3 all of which are now both EOL. (Even Ruby 3.0 is EOL, but we can support it for now.)

johnnyshields commented 4 months ago

@pitbulk this is ready for your review now.

pitbulk commented 4 months ago

I only have the concern of the ruby-saml version, the rest seems good to be merged.

Do you want to fix this at this PR or later?

We should also, after the PR 685, apply somehow adapted versions of:

johnnyshields commented 4 months ago

@pitbulk I've bumped the version to 2.0.0

681 and #679 are both already handled on the v2 branch as part of my Rubocop fixes you merged yesterday. Both those PRs can be closed.

Let's merge this one!