search

SAML-Toolkits / ruby-saml

SAML SSO for Ruby
MIT License
924 stars 566 forks source link

v2.0: Remove deprecated settings.security[:embed_sign] parameter #690

Closed johnnyshields closed 4 months ago

johnnyshields commented 4 months ago

This is a cleanup of https://github.com/SAML-Toolkits/ruby-saml/issues/606

johnnyshields commented 4 months ago

@pitbulk ready for your review and merge.

Since :embed_sign was deprecated in v1.3 I think it's safe to just remove it outright. In general, the correct params should already be set by IdPMetadataParser.

By the way, if we want to do a deprecation warning here, we'd have to do something like: https://github.com/SAML-Toolkits/ruby-saml/issues/694

pitbulk commented 4 months ago

Let's resolve conflicts and we can merge this.