[READY] v2.0 - Consistently format cert/private key PEMs

SAML-Toolkits / ruby-saml

SAML SSO for Ruby

MIT License

924 stars 566 forks source link

[READY] v2.0 - Consistently format cert/private key PEMs #711

Closed johnnyshields closed 2 months ago

johnnyshields commented 4 months ago

Fixes https://github.com/SAML-Toolkits/ruby-saml/issues/636

I've tried to make this as compatible as possible with the legacy behavior while still handling the case stripping out text before/after the PEM string.

All existing test cases behave as before (* see comment below--there's one case that needed a minor alteration as the case itself was written incorrectly.)

johnnyshields commented 4 months ago

@pitbulk this is ready for your review and merge.