SAP-archive / cloud-s4-sdk-pipeline

The Cloud SDK pipeline uses the Cloud SDK continuous delivery server for building, checking, and deploying extension applications. Projects based on the SAP Cloud SDK archetype will automatically use this pipeline.
Apache License 2.0
65 stars 25 forks source link

Config schema validation warnings not up to date #35

Closed hapreanmanuel closed 4 years ago

hapreanmanuel commented 4 years ago

Hello developers,

I see two warning messages in the Config schema validation warnings panel in Jenkins

Issue Description

image The warnings displayed after the deployment seem to be outdated. From the documentation of pipeline v32. the artifactDeployment.nexus now has 'mavenRepository' and 'npmRepository' instead of 'repository' property. image

A similar situation is happening for lint.ui5BestPractices where we use the new flag instead of the deprecated one image

The pipeline is not failing, but the schema validation warnings are faulty

Search for existing solution beforehand

I assume the config schema validation team is already working on keeping up with the pipeline releases, but I still tought it might be helpful to report this issue here.

Kind Regards, Manu

fwilhe commented 4 years ago

Hi @hapreanmanuel

Thanks for the heads up. I've opened a PR in the schema store to update the pipeline. This should not have happened.

Kind regards,

Florian

fwilhe commented 4 years ago

Should be resolved