search

SAP / cloud-sdk-js

Use the SAP Cloud SDK for JavaScript / TypeScript to reduce development effort when building applications on SAP Business Technology Platform that communicate with SAP solutions and services such as SAP S/4HANA Cloud, SAP SuccessFactors, and many others.
Apache License 2.0
161 stars 54 forks source link

Unable to retrieve destination properties in mail-client #4425

Open PPG-BrianChan opened 7 months ago

PPG-BrianChan commented 7 months ago

Dear experts,

We are attempting to send mails using the mail-client package. However,Mail destination information required such as host and port cannot be retrieved during execution. This is because in the source code https://github.com/SAP/cloud-sdk-js/blob/main/packages/mail-client/src/mail-client.ts#L54-L69, it is retrieving the values from "originalProperties", but in reality there is an additional property "destinationConfiguration" encapsulating the values.

To Reproduce

  1. Set up ... Configure a mail destination in subaccount with mail.host, mail.port and other required information in additional properties. A sample we used is https://help.sap.com/docs/build-process-automation/sap-build-process-automation/configuring-smtp-mail-destination?version=Cloud

Prepare a CAP project and include the mail-client package. Pass the destination name into the function "sendMail" along with simple mail config.

  1. Execute Execute CAP project in hybrid testing or deployed mode.

  2. Confirm Error message will be caught.

  3. See error Error will be logged as attached in screenshots.

Screenshots Error log:

image

Destination Configurations:

Destination configurations

Used Versions:

Impact / Priority We intend of making use the same package in all applications that will be sending mails but currently have to resort to a custom solution.

Affected development phase: Development

Impact: Impaired

Additional context A similar issue is raised in the comment of the blog https://blogs.sap.com/2023/02/14/connecting-on-premise-mail-destination-using-sap-cloud-sdk-javascript-version-3-on-sap-cap/ FYI the same destination can be used by SBPA.

deekshas8 commented 7 months ago

Hi @PPG-BrianChan ,

Thanks for raising this. I was able to reproduce this. I'll create a ticket for this in our backlog and update you once we have a fix.

FlorianFechterTCon commented 6 months ago

Hey @deekshas8,

we ran into the same issue. So we would like to know if there is a "roadmap" when this'll be solved?

Greetings

Paran90 commented 2 months ago

Hey @deekshas8 ,

I am attempting to send mails using the destination mail service. But I am facing the same error as mentioned by others in the thread.

Kindly suggest me if there is a workaround to fix this issue.

Thanks and Regards, Paran