search

SAP / cloud-sdk

The SAP Cloud SDK documentation and support repository.
https://sap.github.io/cloud-sdk/
Apache License 2.0
43 stars 38 forks source link

HttpClient Middleware is not a middleware #1829

Open nazarkulyk opened 3 weeks ago

nazarkulyk commented 3 weeks ago

Please review your concept for http client adapter and documentation for it on:

https://sap.github.io/cloud-sdk/docs/js/features/middleware#benefits-of-middlewares

Let us know how we can improve

Providing custom adapter to make own http requests over node-fetch, undici or other API should be called as "adapter" and not "middleware". Middleware is something you will chain to work on http response. You are providing adapter on this place...

Thanks

nazarkulyk commented 3 weeks ago

image