SAP / fundamental-ngx

Fundamental Library for Angular is SAP Design System Angular component library
https://sap.github.io/fundamental-ngx
Apache License 2.0
261 stars 125 forks source link

[P2] fdp-table scrolling updates #11491

Open mikerodonnell89 opened 4 months ago

mikerodonnell89 commented 4 months ago

The table scrolling behavior must be reworked to more closely match that of the ui5 grid table: https://sapui5.hana.ondemand.com/#/entity/sap.ui.table.Table/sample/sap.ui.table.sample.Basic

Notable differences are:

https://github.com/SAP/fundamental-ngx/assets/2471874/6495c774-6840-4d3c-b8c9-2cba0f6b799b

This is tricky to explain, because from the developer's perspective, it's the same <td> that is focused. But from the user's perspective, the focus has changed cells.

This will be released as a significant breaking change to the existing virtual scrolling functionality of the platform table. If these changes are downported to a previous version of fundamental-ngx, it will need to be released as a separate feature, so as to not break the existing functionality for users on fundamental-ngx using ng15 etc

droshev commented 3 months ago

@mikerodonnell89 what happened to that issue?

mikerodonnell89 commented 2 months ago

Deleted some comments to consolidate the needed changes into the original post