SAP / fundamental-ngx

Fundamental Library for Angular is SAP Design System Angular component library
https://sap.github.io/fundamental-ngx
Apache License 2.0
269 stars 129 forks source link

[Accessibility: ACC-264.1] Button: Ensure ARIA roles, states, and properties are valid. #12693

Open gere97 opened 2 weeks ago

gere97 commented 2 weeks ago

Is this a bug, enhancement, or feature request?

Bug

Describe your proposal.

Developers must use valid markup and follow the rules of the ARIA specification, the fd-button has invalid ARIA attributes.

Can you handle that on the application side

No

Which versions of Angular and Fundamental Library for Angular are affected? Please, specify the exact version. (If this is a feature request, use current version.)

All

If this is a bug, please provide steps for reproducing it; the exact components you are using;

https://sap.github.io/fundamental-ngx/#/core/button

Code snippet: <button aria-description=”emphasized” aria-label=”Go” type=”button” class=”fd-button fd-button–emphasized” title=”Go” label=”Go” id=”goBtn” fdtype=”emphasized” fdcompact=”” fd-button=”” fd-toolbar-item=”” _ngcontent-ng-c2812333002=””><span class=”fd-button__text ng-star-inserted”>Go.

Please provide relevant source code (if applicable).

Please provide stackblitz example(s).

In case this is Accessibility related topic, did you consult with an accessibility expert? If not, please do so and share their recommendations.

Yes, issue is raised by an accessibility expert.

Did you check the documentation and the API?

Yes

Did you search for similar issues?

Yes

Is there anything else we should know?

IMPORTANT: Please refrain from providing links or screenshots of SAP's internal information, as this project is open-source, and its contents are accessible to anyone.

droshev commented 2 weeks ago

@gere97 Can you give us more context about your testing, finding, and expectations? thanks