SAP / fundamental-ngx

Fundamental Library for Angular is SAP Design System Angular component library
https://sap.github.io/fundamental-ngx
Apache License 2.0
263 stars 126 forks source link

[Sourcing][Accessibility] Redundant text is read out on accessing side navigation list using keyboard #9537

Closed I543348 closed 1 year ago

I543348 commented 1 year ago

Is this a bug, enhancement, or feature request?

bug

Briefly describe your proposal.

Some labels cannot be perceived efficitenly by disabled user because thye contain redundant role information For eg: the entries of tree structure inside side nav are labelled with "tree item". This is not required and confuses the user.

This is reported by Deutsche telekom customer

Which versions of Angular and Fundamental Library for Angular are affected? (If this is a feature request, use current version.)

Angular 15 core / platform: 0.39.1-rc-5

If this is a bug, please provide steps for reproducing it.

This is replicable on https://sap.github.io/fundamental-ngx/#/core/side-navigation

Screenshot 2023-03-17 at 5 38 37 PM

Please provide relevant source code if applicable.

Is there anything else we should know?

fkolar commented 1 year ago

What I see, The Tree Item XXXX, should be ok, as this is navigation menu. Please see: https://sapui5.hana.ondemand.com/#/entity/sap.ui.webc.fiori.SideNavigation/sample/sap.ui.webc.fiori.sample.SideNavigation

The only difference is in UI5 it says XXX Tree Item , in fundamentals it Tree Item XXX.

Not sure what is right but the information is there and unless we understand the order, here I recommend to reach out to Accessibility team if this is a issue, if the order matters. .

@I543348 , @droshev

I543348 commented 1 year ago

Hi @fkolar Since its a flat list , "tree item" is redundant here and confuses the disabled users (blind users etc)

droshev commented 1 year ago

@I543348 Vertical Navigation is the successor of this Side Nav. Can you validate that issue there?

I543348 commented 1 year ago

Thanks @droshev , I evaluated "vertical navigation" and found that some issue exists there as well - https://github.com/SAP/fundamental-ngx/issues/9608

droshev commented 1 year ago

As the vertical nav is the successor we will be removing this component soon