SAP / fundamental

Fundamental Library - SAP Design System Component Library
https://fundamental.netlify.app/
Apache License 2.0
271 stars 56 forks source link

Bug: A11y: Link vs text contrast does not meet WCAG guidelines #1297

Closed mobot11 closed 1 year ago

mobot11 commented 5 years ago

Describe the bug A clear and concise description of what the bug is.

Is this issue related to a specific component?

What version of the Fiori Fundamentals are you using?

What offering/product do you work on? Any pressing ship or release dates we should be aware of?

What front-end framework are you implementing in, e.g., Angular, React, etc.?

To Reproduce Steps to reproduce the behavior:

  1. Go to https://webaim.org/resources/linkcontrastchecker/
  2. Type in the default text color, #32363a and the default link color, #085caf
  3. See failure

Expected behavior The default text and link color should have at least a 3:1 ratio for WCAG A guidelines.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context Possible fixes are adding an underline or changing the hex values so they meet contrast specifications.

Relates to: https://github.com/SAP/fundamental-react/issues/460

jbadan commented 5 years ago

Medium buttons (orange) do not meet 4.5:1 color contrast standards as well.

Medium: insufficient color contrast of 3.03 (foreground color: #e9730c, background color: #ffffff, font size: 10.5pt, font weight: normal). Expected contrast ratio of 4.5:1