SAP / open-ux-odata

Enable community collaboration to jointly promote and facilitate best in class framework and tooling capabilities when working with OData services.
Apache License 2.0
51 stars 10 forks source link

BUG - mockserver has issue with "editing status" ALL #463

Closed besa1622 closed 1 year ago

besa1622 commented 1 year ago

Description

Hello colleagues, Please, check this case. We use the mockdata as usual (taken from the "real" data response). you can see it here https://github.tools.sap/S4-FIORI-CORE-1/i2d.eam.workorder.manages1/blob/main/webapp/localService/mockdata/MaintenanceOrderUi.json

Currently, the mockserver does not read the mockdata with the default filter "editing status" ALL, but if you change the filter value to "ALL(hiding drafts)" then you will see the data.

Steps to Reproduce

Steps to reproduce the behavior:

  1. clone the app https://github.tools.sap/S4-FIORI-CORE-1/i2d.eam.workorder.manages1
  2. execute it via "npm run start-mock"
  3. click GO in the app (you will see nothing)
  4. change the filter "editing status" value "ALL(hiding drafts)" and click GO - you will see the data

Expected results

With "editing status" ALL - I expect to see this image

Actual results

With "editing status" ALL - I see nothing image

If we populated the mockdata incorrectly then I would like to understand how to do it correctly. This was taken from the real data response(and it was working 1-month ago): "HasDraftEntity": false, "DraftUUID": "00000000-0000-0000-0000-000000000000", "HasActiveEntity": false, "IsActiveEntity": true, "DraftAdministrativeData": null,

======================== FYI. The generator of testing data does not work in VCS, see screenshots. I have no clue why it crashes, for our app, it is fine when @SAP__common.ValueListForValidation' has NO default value.

image

image

Thanks!

nlunets commented 1 year ago

Hi @UDZQDNPW for the generator part i am not involved there. Using @sap-ux/ui5-middleware-fe-mockserver": "2.1.54" will solve your issue for now.

@drktfl this seems to be broken since your lazy converter change, the annotations which are defined with an aliased are not unaliased and we are then lost :) Can you have a look ?

besa1622 commented 1 year ago

@nlunets Thanks!

drktfl commented 1 year ago

Hi, this should be fixed in @sap-ux/ui5-middleware-fe-mockserver@2.1.69.