search

SAP / open-ux-tools

Enable community collaboration to jointly promote and facilitate best in class tooling capabilities
Apache License 2.0
83 stars 41 forks source link

BUG - Sonar: Promises should not be misused #1159

Open kranthie-sap opened 1 year ago

kranthie-sap commented 1 year ago

Description

The following bugs wit 'major' priority are reported in sonar cloud:

  1. Promise returned in function argument where a void return was expected. Promises should not be misused typescript:S6544 packages/.../src/components/UITable/UITable-helper.tsx link to issue

  2. Promise-returning function provided to property where a void return was expected. Promises should not be misused typescript:S6544 packages/ui5-proxy-middleware/src/ui5/middleware.ts link to issue

kranthie-sap commented 1 year ago

It looks like the sonar bugs still exist. Needs further investigation. Another issue to investigate is that SonarCloud bot comment in the PR doesn't seem to report the bugs. The comment had '0 bugs' reported.