SAP / styleguides

This repository provides SAP style guides for coding and coding-related topics.
Other
1.68k stars 445 forks source link

Using alias for interface members and && to split long texts #212

Closed shafiq2601 closed 3 years ago

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

shafiq2601 commented 3 years ago

Please review the sections I have added. I have observed the anti-pattern being practiced by a lot of developers. Let me know for any required modification.

larshp commented 3 years ago

I see use of ALIASES as an anti-pattern, aliases become necessary due to bad OO design IMHO

shafiq2601 commented 3 years ago

True. But when we inherit from legacy interfaces, the interface name is long sometimes and in that scenario, I believe aliases does help tidying up the code for me.

larshp commented 3 years ago

yea, then suggest adding a note that this is useful for legacy interfaces, and when designing new OO use of aliases should be minimized?

shafiq2601 commented 3 years ago

@larshp: Did you also check "use && to split long texts" part?