Closed priyasingh199885 closed 1 year ago
Nice progress! Some points to check:
- [ ] all abap-code-review/src/*.md files should be deleted because everything is contained in one single abap-code-review/ABAPCodeReview.md file
- [ ] markdown-linkcheck should be integrated in package.json scripts
- [ ] README.md and abap-code-review/README.md need to be adjusted to new files and build process
What are the changes needed in README.md? and abap-code-review/Readme.md too?
What are the changes needed in README.md? and abap-code-review/Readme.md too?
build is currently failing:
npm ci
can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file withnpm install
before continuing.
That means you need to git add+commit+push either a package-lock.json or npm-shrinkwrap.json in your branch
@priyasingh199885: Thanks! Great contribution!
This PR is only to pre-view the changes and not necessarily be approved or merged.