SAP / ui5-linter

A static code analysis tool for UI5
Apache License 2.0
52 stars 4 forks source link

Ignore check of unmatched patterns #373

Open Shingaz opened 1 month ago

Shingaz commented 1 month ago

Is your feature request related to a problem? Please describe.

It is very difficult to use the ui5linter in conjuction with lint-staged. To avoid to lint the whole project before commiting, we use lint-staged lint only files staged for commit.

The lint-staged configuration is this one:

const ui5lint = (filenames) => `ui5lint ${filenames.join(" ")}`;

export default {
  "webapp/**/*": (stagedFiles) => ui5lint(stagedFiles),
};

Depending on what is staged for commit, some files can be included in the resulting command but ui5lint is not able to process them. For example:

ui5lint webapp/test/integration/mock/metadata.xml webapp/view/Main.view.xml 

In this case, as webapp/test/integration/mock/metadata.xml cannot be processed by ui5lint, the whole command fails.

Describe the solution you'd like

Have a parameter to ignore files that cannot be processed. Similarly to Prettier --ignore-unknown for example.

Describe alternatives you've considered

Monkey patch the ui5-linter library.

Additional context

Add any other context or screenshots about the feature request here.

flovogt commented 2 weeks ago

@Shingaz Thanks a lot for opening this enhancement request. Great Idea! We will implement this feature with backlog item CPOUI5FOUNDATION-955