search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.46k stars 253 forks source link

[SF][IllustratedMessage]: NoEntries subtitle text missing single quote in British English #9082

Open summer2200 opened 1 month ago

summer2200 commented 1 month ago

Describe the bug

After switching language to British English, NoEntries IllustratedMessage's subtitle missed one single quote.

Screenshot 2024-05-29 at 17 02 25

Isolated Example

https://sap.github.io/ui5-webcomponents-react/?path=/docs/user-feedback-illustratedmessage--docs&globals=language:en_GB

Reproduction steps

  1. Open the link, set illustrated message name to "NoEntries"
  2. Select "British English" in language picker
  3. See the subtitle

Expected Behaviour

Subtitle should be "..., you'll ..."

Screenshots or Videos

No response

UI5 Web Components for React Version

1.28.4

UI5 Web Components Version

1.24.3

Browser

Chrome

Operating System

macOS Sonoma 14.3.1

Additional Context

No response

Relevant log output

No response

Organization

No response

Declaration

MarcusNotheis commented 1 month ago

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

plamenivanov91 commented 1 month ago

Hello @SAP/ui5-webcomponents-topic-p,

The problem is that in the en_GB translation file (probably in some others too), the single quote/apostrophe is not escaped as is in the original message bundle file.

The escape can be done by inserting another single quote next to it, or write down the unicode (\u2019) for the single quote instead of it.

My guess is that the issue should be forwarded to the translation team.

Could you please look into it?

Regards, Plamen Ivanov

plamenivanov91 commented 3 weeks ago

Hello @summer2200 ,

There is an internal ticket DINC0147183 where the issue is being currently resolved.

Regards, Plamen Ivanov