SBC-Utrecht / PyTom

PyTom software for cryo-tomogram processing
GNU General Public License v2.0
33 stars 8 forks source link

particle picker subtomo deselection bug #31

Open McHaillet opened 2 years ago

McHaillet commented 2 years ago

Heard this issue from multiple people. When the radius of circle object in particle picker GUI starts overlapping, issues occur where one mouse click deselects two (or more) particles. For larger radii the issue increases. This likely has something to do with the radius calculation between mouse location and circle object center. But need to look further into the code for the specific issue.

McHaillet commented 1 year ago

Lena's description of the bug:

This usually happens for large box sizes when in xy there is too much overlap with another particle even though the z coordinate should clearly distinguish the centers.

Example: e50c4593-f48c-4880-998d-2e8c0460e607

It happens when right clicking on particles in the subtomo overview window (the one with all the particles sorted bz score).

When right clicking in the tomogram view (s. Screenshot) it doesnt happen if there is a spot (e.g. the space between the outer and inner particle border) that is clearly only removing one of the particles.

If I click where the orange arrow points I can safely remove one particle without removing the other one: 4764788f-9314-4c0d-9aec-3e4ac16ff39f

For smaller box sizes it does not happen.

McHaillet commented 1 year ago

I looked if I could find the bug, but was hard to see where it comes from directly.