search

SBNSoftware / icaruscode

Main/top level repository for ICARUS specific code
11 stars 33 forks source link

Fixes from Clang compilation errors #749

Open PetrilloAtWork opened 2 months ago

PetrilloAtWork commented 2 months ago

Clang 14 (c14:prof) complains about a few lines of code. While the merit of the complains is arguable (not plain wrong, nor right), "fixing" the code is cheap, and needed if we want to compile with Clang. The fixes are simple and technical.

Reviewers: who is the Collaboration C++ expert?

SFBayLaser commented 2 months ago

If you translate from C++ to FORTRAN II then I will be happy to review.

mmrosenberg commented 2 months ago

trigger build SBNSoftware/icarusalg#87

FNALbuild commented 2 months ago

:heavy_check_mark: CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild commented 2 months ago

:heavy_check_mark: CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild commented 2 months ago

:warning: CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

:rotating_light: For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild commented 2 months ago

:x: CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for c14:prof - ignored failure for unit_test - ignored warnings for build -- details available through the CI dashboard

:rotating_light: For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard