search

SBRG / cobrame

A COBRApy extension for genome-scale models of metabolism and expression (ME-models)
Other
34 stars 17 forks source link

COBRAme JSON loading #3

Closed zakandrewking closed 7 years ago

zakandrewking commented 7 years ago

I was expecting load_json_me to return a COBRAme model.

On a related note, the naming of MEModel (filename) vs MEmodel (class name) is a little confusing.

Thanks for working through all these details!!

coltonlloyd commented 7 years ago

Thanks for pointing out the naming inconsistency. It was corrected as part of bf7982b

As for the JSON serialization, I updated the documentation of this function to make clear that it will load a COBRApy Model. Also, I pushed a rough draft of scripts to allow full JSON serialization to a new branch called "json". This will ideally let us load a fully functioning MEModel from a JSON object. Both of these changes can be found in fcd2d76.