search

SCBI-ForestGEO / McGregor_climate-sensitivity-variation

repository for linking the climate sensitity of tree growth (derived from cores) to functional traits
0 stars 0 forks source link

Represent 'year' in Tables S6 and S7. #123

Closed teixeirak closed 3 years ago

teixeirak commented 3 years ago

@mcgregorian1 , In order for Tables S6 and S7 to be complete, they need to give the coefficients for year, even though the effect was not significant. Alternatively, at a minimum we should specify that year was included, but was not significant, so coefficients are not shown.

mcgregorian1 commented 3 years ago

This is easy enough to do and I can add it in tonight - I have a place in the code where I specifically remove it, so I just need to comment out that line and change some column headings.

On Tue, Jul 21, 2020 at 12:05 PM Kristina Anderson-Teixeira < notifications@github.com> wrote:

@mcgregorian1 https://github.com/mcgregorian1 , In order for Tables S6 and S7 to be complete, they need to give the coefficients for year, even though the effect was not significant. Alternatively, at a minimum we should specify that year was included, but was not significant, so coefficients are not shown.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SCBI-ForestGEO/McGregor_climate-sensitivity-variation/issues/123, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJNRBEIVDGOUKQ2JQXOYJ6LR4W4DXANCNFSM4PDYA66Q .

--

Ian McGregor

Ph.D. Student | Center for Geospatial Analytics

He/Him/His

College of Natural Resources

Jordan Hall 4120 | Campus Box 7106

North Carolina State University

2800 Faucette Dr.

Raleigh, NC 27695 USA imcgreg@ncsu.edu | 714-864-1005 | geospatial.ncsu.edu

teixeirak commented 3 years ago

Okay, thanks.

Kristina J. Anderson-Teixeira Ecologist, Leader of ForestGEO Ecosystems & Climate Program Smithsonian Institution Smithsonian Conservation Biology Institute 1500 Remount Rd. MRC 5535; Front Royal, VA 22630 USA 1-540-635-6546 | teixeirak@si.edumailto:teixeirak@si.edu CTFS-ForestGEO Ecosystems & Climate Program https://forestgeo.si.edu/research-programs/ecosystems-and-climate-program Lab Websitehttps://sites.google.com/site/forestecoclimlab/home

From: Ian McGregor notifications@github.com Reply-To: SCBI-ForestGEO/McGregor_climate-sensitivity-variation reply@reply.github.com Date: Tuesday, July 21, 2020 at 12:18 PM To: SCBI-ForestGEO/McGregor_climate-sensitivity-variation McGregor_climate-sensitivity-variation@noreply.github.com Cc: "Teixeira, Kristina A." TeixeiraK@si.edu, Author author@noreply.github.com Subject: Re: [SCBI-ForestGEO/McGregor_climate-sensitivity-variation] Represent 'year' in Tables S6 and S7. (#123)

External Email - Exercise Caution This is easy enough to do and I can add it in tonight - I have a place in the code where I specifically remove it, so I just need to comment out that line and change some column headings.

On Tue, Jul 21, 2020 at 12:05 PM Kristina Anderson-Teixeira < notifications@github.com> wrote:

@mcgregorian1 https://github.com/mcgregorian1 , In order for Tables S6 and S7 to be complete, they need to give the coefficients for year, even though the effect was not significant. Alternatively, at a minimum we should specify that year was included, but was not significant, so coefficients are not shown.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SCBI-ForestGEO/McGregor_climate-sensitivity-variation/issues/123, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJNRBEIVDGOUKQ2JQXOYJ6LR4W4DXANCNFSM4PDYA66Q .

--

Ian McGregor

Ph.D. Student | Center for Geospatial Analytics

He/Him/His

College of Natural Resources

Jordan Hall 4120 | Campus Box 7106

North Carolina State University

2800 Faucette Dr.

Raleigh, NC 27695 USA imcgreg@ncsu.edu | 714-864-1005 | geospatial.ncsu.edu

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSCBI-ForestGEO%2FMcGregor_climate-sensitivity-variation%2Fissues%2F123%23issuecomment-661959140&data=02%7C01%7Cteixeirak%40si.edu%7Cb5146e464d3e422a15d008d82d91c39c%7C989b5e2a14e44efe93b78cdd5fc5d11c%7C0%7C0%7C637309451373914613&sdata=54bz9u%2B1X40Z1Su7funloVS8m5bniqFAZqQa4b%2BwM5o%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABQPXDTMGSRI5D6SOIRCO73R4W5W5ANCNFSM4PDYA66Q&data=02%7C01%7Cteixeirak%40si.edu%7Cb5146e464d3e422a15d008d82d91c39c%7C989b5e2a14e44efe93b78cdd5fc5d11c%7C0%7C0%7C637309451373924601&sdata=0yBE%2BlTlXiBILLD%2BbJNyr%2B7GBiUr77%2BX31yqDwJbDUs%3D&reserved=0.

mcgregorian1 commented 3 years ago

Hm so I checked and "year" has a coefficient of 0 for all 4 top models for Rt and Rt_arima. I maybe it would be better if we just mention it wasn't significant, so we did not include it in the table in order to have a more parsimonious table?

teixeirak commented 3 years ago

Sounds good.

teixeirak commented 3 years ago

Hm so I checked and "year" has a coefficient of 0 for all 4 top models for Rt and Rt_arima. I maybe it would be better if we just mention it wasn't significant, so we did not include it in the table in order to have a more parsimonious table?

Actually, returning here. There should be 3 coefficients --one for each drought year. I suspect you're just looking at the first.

mcgregorian1 commented 3 years ago

Right sorry. The "year" wasn't being treated categorically. I've changed it and while it doesn't change the results, I do need to go back through and update S4-S6 slightly for coefficient/dAIC values.

I'm still going to assume that we will not include year in the final coefficient table as it is insignificant.

For Rt, the year coefficients are this for the top 4 models: image

For Rt_arima they are this image

teixeirak commented 3 years ago

Thanks. I think it will be best to include these coefficients in the table footnotes.