SD2E / experimental-intent-parser

A tool that combines a word-processing interface with structured tables and assisted linking to definitions to provide a simple interface for incremental codification of experiment designs.
BSD 3-Clause "New" or "Revised" License
4 stars 0 forks source link

Infer non-variable controls #92

Open mwes opened 4 years ago

mwes commented 4 years ago

In GitLab by @jakebeal on Aug 21, 2019, 06:53

Each modality of measurement implies some non-variable controls, which can be automatically inferred from the measurement table.

I don't think the omics measurements have any fixed calibrants at present, though RNAseq should be using SRM 2374, a NIST calibration system for RNAseq https://www-s.nist.gov/srmors/view_detail.cfm?srm=2374

mwes commented 4 years ago

In GitLab by @jakebeal on Oct 14, 2019, 10:17

removed assignee

mwes commented 4 years ago

In GitLab by @jakebeal on Oct 25, 2019, 10:31

Related to #92 , might be obsolete depending on how @mweston's tables actually look.

mwes commented 4 years ago

In GitLab by @mweston on Oct 25, 2019, 10:47

These should be declared explicitly, not inferred - not all measurements include these control elements unless it's actually part of the design. We have support for this in the SR by three booleans:

has_fluorescence_calibration has_size_calibration has_igem_calibration

Example: https://gitlab.sd2e.org/sd2program/cp-request/blob/master/input/structured_requests/nand_2_0_omics.json#L131

Presence of these automatically inlines a re-usable measurement for each of these controls:

https://gitlab.sd2e.org/sd2program/cp-request/blob/master/references/flow_bead_fluorescence_calibration.json https://gitlab.sd2e.org/sd2program/cp-request/blob/master/references/flow_bead_size_calibration.json https://gitlab.sd2e.org/sd2program/cp-request/blob/master/references/igem_plate_reader_calibration.json

mwes commented 4 years ago

In GitLab by @jakebeal on Oct 27, 2019, 12:36

OK, @mweston, per your comment we won't infer controls. Instead, let's transform this into a warning in the validator when expected controls are not present.