search

SEL-Columbia / SEL-Columbia.github.io

qSEL's website
http://qsel.columbia.edu
3 stars 2 forks source link

Styling - Make sure that Bootstrap uses 'col-*-*' instead of 'span*' #7

Closed Nasafato closed 8 years ago

Nasafato commented 9 years ago

The site uses Bootstrap for styling, along with, of course, some custom CSS.

However, the version used in the old site is Bootstrap 2 - since then, Bootstrap has been updated to version 3. Here's a Stackoverflow explanation of this.

The syntax for its grid-based system used to use: 

<div class="span4">...</div>

But Bootstrap 3 uses:

<div class="col-md-4"></div>

So when updating the styling for what the page will look like, just keep in mind to use Bootstrap 3 instead of Bootstrap 2.

vr2262 commented 8 years ago

@Nasafato Does this mean that the existing pages need to be updated?

$ git grep span1
blog/old_index.md:  <div class="span12">
blog/old_index.md:    <div class="span11">
projects/_posts/2015-12-07-millenium-villages-project.md:  <div class="span12">
projects/_posts/2015-12-07-millenium-villages-project.md:  <div class="span12">
projects/_posts/2015-12-07-millenium-villages-project.md:    <div class="span12">
projects/_posts/2015-12-07-millenium-villages-project.md:            <div class="span12">
projects/_posts/2015-12-07-millenium-villages-project.md:              <div class="span12">
projects/_posts/2015-12-07-quench.md:  <div class="span12">
projects/_posts/2015-12-07-quench.md:  <div class="span12" style="padding:0px 0px 0px 30px;">
projects/_posts/2015-12-07-quench.md:  <div class="span12">
projects/_posts/2015-12-07-scale-up-initiative.md:  <div class="span12">
projects/_posts/2015-12-07-shared-solar.md:  <div class="span12">
projects/_posts/2015-12-07-smart-solar-irrigation.md:  <div class="span12">
projects/_posts/2015-12-07-smart-solar-irrigation.md:  <div class="span12" style="padding:0px 0px 0px 30px;">
projects/_posts/2015-12-07-smart-solar-irrigation.md:  <div class="span12">
projects/_posts/2015-12-07-sustainable-energy-solutions-program-in-west-africa.md:  <div class="span12">
projects/_posts/2015-12-08-delhi-energy-project.md:  <div class="span12">
chrisnatali commented 8 years ago

@vr2262 we're not doing this, right? If we get a designer, they may re-structure it.

vr2262 commented 8 years ago

@chrisnatali that is correct.